Evaluate code in playground #415
Conversation
| @@ -13,16 +13,16 @@ module Make: (Config: Config) => | |||
| include Config | |||
|
|
|||
| module App: { | |||
| let postMessage: (worker, fromApp) => unit | |||
There was a problem hiding this comment.
Without these changes I was getting type errors. I posted about it on the forum: https://forum.rescript-lang.org/t/regarding-src-bindings-worker-res-in-the-rescript-lang-org-repo/2004/2
src/common/EvalWorker.res
Outdated
| @@ -0,0 +1,10 @@ | |||
| // Required because workers may receive messages intended for other workers eg. react dev tools | |||
There was a problem hiding this comment.
Ok, stuck again. This module seems to be being executed inside of the window and not actually in a worker. Very confused at this point...
There was a problem hiding this comment.
All of the examples I've seen online in Webpack5 and Next.js are passing URL instances to new Worker whereas I am passing url.toString(), changing it to be let make = () => %raw(new Worker(new URL("./EvalWorker.mjs", import.meta.url))) breaks with the following error:
webpack/runtime/compat
The "path" argument must be of type string. Received undefined
There was a problem hiding this comment.
hmm, where does path come from? weird
There was a problem hiding this comment.
I found this issue which seems kinda related but is about dynamic imports inside a worker: vercel/next.js#22581
There was a problem hiding this comment.
That issue is the exact problem and the config workaround does the trick. See my comment here: vercel/next.js#22581 (comment)
Definitely not an ideal solution, I'll look into testing the attached PR and hopefully we can get a patch merged.
There was a problem hiding this comment.
Ok, this is definitely fixed with vercel/next.js#26372
There was a problem hiding this comment.
For now I've added a monkey patch in the next config...
|
Superseded by #875 🎉 |
Closes #414
Evalmodule that uses aWorkerunder the hood, it exposes a state machine